Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only warn about miniflare feature support (ai, vectorize, cron) once #6331

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

threepointone
Copy link
Contributor

@threepointone threepointone commented Jul 24, 2024

image

We have some warnings in local mode dev when trying to use ai bindings / vectorize / cron, but they are printed every time the worker is started. This PR changes the warning to only be printed once per worker start.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: a simple dx tweak
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: no functional change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: no functional changes

…once

We have some warnings in local mode dev when trying to use ai bindings / vectorize / cron, but they are printed every time the worker is started. This PR changes the warning to only be printed once per worker start.
Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: 68f4e88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@threepointone threepointone marked this pull request as ready for review July 24, 2024 21:17
@threepointone threepointone requested a review from a team as a code owner July 24, 2024 21:17
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10084161896/npm-package-wrangler-6331

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6331/npm-package-wrangler-6331

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10084161896/npm-package-wrangler-6331 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10084161896/npm-package-create-cloudflare-6331 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10084161896/npm-package-cloudflare-kv-asset-handler-6331
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10084161896/npm-package-miniflare-6331
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10084161896/npm-package-cloudflare-pages-shared-6331
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10084161896/npm-package-cloudflare-vitest-pool-workers-6331

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.66.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240718.0
workerd 1.20240718.0 1.20240718.0
workerd --version 1.20240718.0 2024-07-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa
Copy link
Contributor

Might be nice to add a helper to the global logger for this? logger.warnOnce or something?

@RamIdeas
Copy link
Contributor

Might be nice to add a helper to the global logger for this? logger.warnOnce or something?

Was thinking the same. It would encourage contributions to not fall into the same ux trap

@threepointone
Copy link
Contributor Author

It's a good idea. I'll leave that up to you folks!

@threepointone threepointone merged commit e6ada07 into main Jul 25, 2024
18 checks passed
@threepointone threepointone deleted the fix-local-mode-noisy-warnings branch July 25, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants