Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that mocked fetch responses have a valid URL property #6362

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

petebacondarwin
Copy link
Contributor

What this PR solves / how to test

Fixes #6350

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: bug fix

@petebacondarwin petebacondarwin requested a review from a team as a code owner July 29, 2024 14:50
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: e547406

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10147086035/npm-package-wrangler-6362

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6362/npm-package-wrangler-6362

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10147086035/npm-package-wrangler-6362 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10147086035/npm-package-create-cloudflare-6362 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10147086035/npm-package-cloudflare-kv-asset-handler-6362
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10147086035/npm-package-miniflare-6362
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10147086035/npm-package-cloudflare-pages-shared-6362
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10147086035/npm-package-cloudflare-vitest-pool-workers-6362

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.67.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240718.1
workerd 1.20240718.0 1.20240718.0
workerd --version 1.20240718.0 2024-07-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin force-pushed the fix-vitest-mock-fetch-response-url branch from 4649361 to e547406 Compare July 29, 2024 15:18
@petebacondarwin petebacondarwin merged commit 35289e3 into main Jul 29, 2024
20 checks passed
@petebacondarwin petebacondarwin deleted the fix-vitest-mock-fetch-response-url branch July 29, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 BUG: fetchMock returns an empty url
2 participants