Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASM modules in versions secrets #6365

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Jul 29, 2024

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: no e2e test changes
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: no new feature

Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: a5932e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 29, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10165915641/npm-package-wrangler-6365

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6365/npm-package-wrangler-6365

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10165915641/npm-package-wrangler-6365 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10165915641/npm-package-create-cloudflare-6365 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10165915641/npm-package-cloudflare-kv-asset-handler-6365
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10165915641/npm-package-miniflare-6365
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10165915641/npm-package-cloudflare-pages-shared-6365
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10165915641/npm-package-cloudflare-vitest-pool-workers-6365

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.67.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240718.1
workerd 1.20240725.0 1.20240725.0
workerd --version 1.20240725.0 2024-07-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev force-pushed the walshy/fix-wasm-modules-in-versions-secret branch 2 times, most recently from 8d0e867 to 1d741e7 Compare July 30, 2024 15:55
@WalshyDev WalshyDev marked this pull request as ready for review July 30, 2024 15:55
@WalshyDev WalshyDev requested a review from a team as a code owner July 30, 2024 15:55
@WalshyDev WalshyDev force-pushed the walshy/fix-wasm-modules-in-versions-secret branch from 1d741e7 to 766128a Compare July 30, 2024 16:04
@WalshyDev WalshyDev force-pushed the walshy/fix-wasm-modules-in-versions-secret branch from 766128a to a5932e5 Compare July 30, 2024 16:10
@RamIdeas RamIdeas merged commit 13549c3 into main Jul 30, 2024
18 checks passed
@RamIdeas RamIdeas deleted the walshy/fix-wasm-modules-in-versions-secret branch July 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants