Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak the properties of the new Wrangler output file entries for… #6440

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

petebacondarwin
Copy link
Contributor

… better consistency

What this PR solves / how to test

In consultation with the CI/CD team, this change is just a simple update to what fields are available on the output file entries.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: does not touch e2e tested code paths
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal experimental

@petebacondarwin petebacondarwin requested a review from a team as a code owner August 7, 2024 19:49
Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: cd51075

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 7, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10290957032/npm-package-wrangler-6440

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6440/npm-package-wrangler-6440

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10290957032/npm-package-wrangler-6440 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10290957032/npm-package-create-cloudflare-6440 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10290957032/npm-package-cloudflare-kv-asset-handler-6440
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10290957032/npm-package-miniflare-6440
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10290957032/npm-package-cloudflare-pages-shared-6440
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10290957032/npm-package-cloudflare-vitest-pool-workers-6440

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.69.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240725.0
workerd 1.20240725.0 1.20240725.0
workerd --version 1.20240725.0 2024-07-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin merged commit 09b5092 into main Aug 8, 2024
18 checks passed
@petebacondarwin petebacondarwin deleted the tweak-output-entries branch August 8, 2024 15:49
@workers-devprod workers-devprod mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants