-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run deploy interactively in C3 #6569
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5c40c78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b179301
to
f673616
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-wrangler-6569 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6569/npm-package-wrangler-6569 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-wrangler-6569 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-create-cloudflare-6569 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-kv-asset-handler-6569 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-miniflare-6569 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-pages-shared-6569 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-vitest-pool-workers-6569 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-workers-editor-shared-6569 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-workers-shared-6569 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
What this PR solves / how to test
Previously, C3 ran
wrangler deploy
andwrangler pages deploy
non-interactively. Since this is intended to be an interactive command, this led to various bugs. However, since C3 parsed the output of Wrangler's deploy command (and that's not possible with an interactive spawn), a change was also needed to how C3 figured out what Wrangler did during a deploy. This PR:Fixes #4915, fixes #4263, fixes #6230
Author has addressed the following