Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run deploy interactively in C3 #6569

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

penalosa
Copy link
Contributor

What this PR solves / how to test

Previously, C3 ran wrangler deploy and wrangler pages deploy non-interactively. Since this is intended to be an interactive command, this led to various bugs. However, since C3 parsed the output of Wrangler's deploy command (and that's not possible with an interactive spawn), a change was also needed to how C3 figured out what Wrangler did during a deploy. This PR:

  • Extends Wrangler's JSON-ND file output for deploy to include the deploy targets
  • Adds an output for a pages deploy operation
  • Runs the deploy command interactively

Fixes #4915, fixes #4263, fixes #6230

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: bugfix

@penalosa penalosa requested review from a team as code owners August 23, 2024 12:00
Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: 5c40c78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
create-cloudflare Patch
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa force-pushed the penalosa/c3-wrangler-interactive branch from b179301 to f673616 Compare August 23, 2024 12:02
Copy link
Contributor

github-actions bot commented Aug 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-wrangler-6569

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6569/npm-package-wrangler-6569

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-wrangler-6569 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-create-cloudflare-6569 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-kv-asset-handler-6569
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-miniflare-6569
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-pages-shared-6569
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-vitest-pool-workers-6569
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-workers-editor-shared-6569
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10525719370/npm-package-cloudflare-workers-shared-6569

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
1 participant