-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C3] Use create-vite instead of create-react-app for React projects #6573
Conversation
🦋 Changeset detectedLatest commit: 4983fbd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-wrangler-6573 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6573/npm-package-wrangler-6573 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-wrangler-6573 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-create-cloudflare-6573 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-kv-asset-handler-6573 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-miniflare-6573 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-pages-shared-6573 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-vitest-pool-workers-6573 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-workers-editor-shared-6573 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-workers-shared-6573 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm supportive of this move, but I also want to bring up that this change was originally proposed in #5891 by @santraez and we didn't process it in a timely manner before @santraez closed the PR.
I suggest we still credit @santraez in the changelog given that he was right about this all along, we just didn't have the capacity to process his suggestion.
Absolutely! And for the record, the reason this is a new PR rather than a rebase of @santraez's original PR is that the fork was deleted. |
* Version Packages * quarantine vue c3 tests * Change author credit for #6573 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Rahul Sethi <5822355+RamIdeas@users.noreply.github.com>
What this PR solves / how to test
React's documentation now recommends using
create-vite
overcreate-react-app
, as the latter has been deprecated. To align with these best practices, React projects created with C3 will now use Vite.With this change, the default development command will switch from using
create-react-app
tocreate-vite
, providing a more modern and efficient development experience.Additionally, selection of variants for React projects created by Vite has been added, allowing users to choose different configurations based on their needs. The test suite has also been adapted to accommodate the new configuration, ensuring all tests run without errors.
Author has addressed the following