Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C3] Use create-vite instead of create-react-app for React projects #6573

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

penalosa
Copy link
Contributor

What this PR solves / how to test

React's documentation now recommends using create-vite over create-react-app, as the latter has been deprecated. To align with these best practices, React projects created with C3 will now use Vite.

With this change, the default development command will switch from using create-react-app to create-vite, providing a more modern and efficient development experience.

Additionally, selection of variants for React projects created by Vite has been added, allowing users to choose different configurations based on their needs. The test suite has also been adapted to accommodate the new configuration, ensuring all tests run without errors.

Author has addressed the following

@penalosa penalosa requested review from a team as code owners August 23, 2024 14:39
Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: 4983fbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-wrangler-6573

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6573/npm-package-wrangler-6573

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-wrangler-6573 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-create-cloudflare-6573 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-kv-asset-handler-6573
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-miniflare-6573
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-pages-shared-6573
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-vitest-pool-workers-6573
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-workers-editor-shared-6573
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10583381337/npm-package-cloudflare-workers-shared-6573

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 😄

Thanks a lot for getting this over the line @penalosa! ❤️

And thank you so very much for the original PR @santraez, it is truly appreciated! 🫶 sorry we didn't notice and merge it for months! 🙇

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm supportive of this move, but I also want to bring up that this change was originally proposed in #5891 by @santraez and we didn't process it in a timely manner before @santraez closed the PR.

I suggest we still credit @santraez in the changelog given that he was right about this all along, we just didn't have the capacity to process his suggestion.

@penalosa
Copy link
Contributor Author

penalosa commented Aug 27, 2024

I'm supportive of this move, but I also want to bring up that this change was originally proposed in #5891 by @santraez and we didn't process it in a timely manner before @santraez closed the PR.

I suggest we still credit @santraez in the changelog given that he was right about this all along, we just didn't have the capacity to process his suggestion.

Absolutely! And for the record, the reason this is a new PR rather than a rebase of @santraez's original PR is that the fork was deleted. I'll modify the changelog to make authorship clear. Looks like we'll have to do that after release given how changesets work. I'll make sure we make that change though.

@penalosa penalosa merged commit 3ff6506 into main Aug 27, 2024
27 checks passed
@penalosa penalosa deleted the santraez/c3-react-new-bundler branch August 27, 2024 19:03
RamIdeas added a commit that referenced this pull request Aug 29, 2024
RamIdeas added a commit that referenced this pull request Aug 30, 2024
RamIdeas added a commit that referenced this pull request Aug 30, 2024
* Version Packages

* quarantine vue c3 tests

* Change author credit for #6573

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rahul Sethi <5822355+RamIdeas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants