Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Publish miniflare@beta to npm #6594

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Aug 28, 2024

What this PR solves / how to test

This PR adds a step in prereleases.yaml to deploy miniflare@beta to npm

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: GH workflow change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: GH workflow change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: GH workflow change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: GH workflow change

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner August 28, 2024 16:35
Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 7c19c4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will this make wrangler@beta depend on miniflare@beta?

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10600768936/npm-package-wrangler-6594

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6594/npm-package-wrangler-6594

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10600768936/npm-package-wrangler-6594 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10600768936/npm-package-create-cloudflare-6594 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10600768936/npm-package-cloudflare-kv-asset-handler-6594
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10600768936/npm-package-miniflare-6594
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10600768936/npm-package-cloudflare-pages-shared-6594
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10600768936/npm-package-cloudflare-vitest-pool-workers-6594
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10600768936/npm-package-cloudflare-workers-editor-shared-6594
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10600768936/npm-package-cloudflare-workers-shared-6594

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu
Copy link
Contributor Author

I think so yeah. We have a similar dependency of wrangler on workers-shared, for which we've put in place a similar construct, and that worked out well

@CarmenPopoviciu CarmenPopoviciu merged commit 1024237 into main Aug 28, 2024
21 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/miniflare-beta branch August 28, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants