Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment alias url to pages deploy #6643

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

WalshyDev
Copy link
Member

What this PR solves / how to test

Fixes #3717

This is inline with how we did Worker previews and makes it easy to grep for usage in workflows.

Examples:

# Production (no alias):
$ node ~/workspace/cloudflare/workers-sdk/packages/wrangler/bin/wrangler.js pages deploy . --project-name test --commit-dirty true
✨ Compiled Worker successfully
🌎  Uploading... (43/43)

✨ Success! Uploaded 1 files (42 already uploaded) (2.28 sec)

✨ Uploading _headers
✨ Uploading _redirects
✨ Uploading Functions bundle
✨ Uploading _routes.json
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://d2b7dfb3.test-dcz.pages.dev

# Staging (has alias)
$ node ~/workspace/cloudflare/workers-sdk/packages/wrangler/bin/wrangler.js pages deploy . --project-name test --commit-dirty true --branch staging
✨ Compiled Worker successfully
🌍  Uploading... (43/43)

✨ Success! Uploaded 1 files (42 already uploaded) (2.08 sec)

✨ Uploading _headers
✨ Uploading _redirects
✨ Uploading Functions bundle
✨ Uploading _routes.json
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://d4290ae3.test-dcz.pages.dev
✨ Deployment alias URL: https://staging.test-dcz.pages.dev

# Grep example
$ node ~/workspace/cloudflare/workers-sdk/packages/wrangler/bin/wrangler.js pages deploy . --project-name test --commit-dirty true --branch staging | grep 'Deployment alias URL' | awk '{pri
nt $5}'
https://staging.test-dcz.pages.dev

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: no e2e coverage
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: just output change

@WalshyDev WalshyDev requested review from a team as code owners September 6, 2024 06:57
Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: 671d63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10834177104/npm-package-wrangler-6643

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6643/npm-package-wrangler-6643

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10834177104/npm-package-wrangler-6643 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10834177104/npm-package-create-cloudflare-6643 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10834177104/npm-package-cloudflare-kv-asset-handler-6643
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10834177104/npm-package-miniflare-6643
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10834177104/npm-package-cloudflare-pages-shared-6643
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10834177104/npm-package-cloudflare-vitest-pool-workers-6643
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10834177104/npm-package-cloudflare-workers-editor-shared-6643
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10834177104/npm-package-cloudflare-workers-shared-6643

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.76.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.2
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

.changeset/angry-socks-pretend.md Outdated Show resolved Hide resolved
@WalshyDev WalshyDev merged commit f30c61f into main Sep 13, 2024
21 checks passed
@WalshyDev WalshyDev deleted the walshy/pages-alias branch September 13, 2024 10:58
@Ambroos
Copy link

Ambroos commented Sep 30, 2024

@WalshyDev or @CarmenPopoviciu - any chance either of you could take a look at the matching PR in wrangler-action, or poke someone internally who can? cloudflare/wrangler-action#291

Thanks!

@WalshyDev
Copy link
Member Author

Yeah I already poked internally - I'll re-ping tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Get alias after wrangler pages deploy
4 participants