-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject latest Durable Object migration state into Miniflare #6647
Conversation
🦋 Changeset detectedLatest commit: 0a1224a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-wrangler-6647 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6647/npm-package-wrangler-6647 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-wrangler-6647 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-create-cloudflare-6647 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-kv-asset-handler-6647 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-miniflare-6647 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-pages-shared-6647 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-vitest-pool-workers-6647 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-workers-editor-shared-6647 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-workers-shared-6647 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
b5477eb
to
3f02e61
Compare
3f02e61
to
2771c0a
Compare
2771c0a
to
c00f6f4
Compare
@penalosa I think this is ready to go. There's one failing test which seems unrelated to my change, but is only reproducible on Windows. Do we have VMs sitting around that we can validate this on? |
This looks generally good! A couple small comments, but otherwise good to go. One question—do DOs with SQlite work in remote mode? We don't seem to be sending migrations to the remote preview system |
c792972
to
a53f532
Compare
a53f532
to
0a1224a
Compare
What this PR solves / how to test
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following