Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject latest Durable Object migration state into Miniflare #6647

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

joshthoward
Copy link
Contributor

@joshthoward joshthoward commented Sep 9, 2024

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: no e2e tests cover DO migrations
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: Covered by SQLite backed DOs announcement and blog post.

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 0a1224a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Minor
wrangler Minor
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 9, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-wrangler-6647

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6647/npm-package-wrangler-6647

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-wrangler-6647 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-create-cloudflare-6647 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-kv-asset-handler-6647
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-miniflare-6647
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-pages-shared-6647
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-vitest-pool-workers-6647
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-workers-editor-shared-6647
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838733213/npm-package-cloudflare-workers-shared-6647

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.77.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.0
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@joshthoward joshthoward force-pushed the joshthoward/migrations-in-miniflare branch 2 times, most recently from b5477eb to 3f02e61 Compare September 11, 2024 12:31
@lrapoport-cf lrapoport-cf added the caretaking Priority for caretaking label Sep 11, 2024
@joshthoward joshthoward force-pushed the joshthoward/migrations-in-miniflare branch from 3f02e61 to 2771c0a Compare September 11, 2024 21:09
@joshthoward joshthoward marked this pull request as ready for review September 11, 2024 21:10
@joshthoward joshthoward requested a review from a team as a code owner September 11, 2024 21:10
@joshthoward joshthoward force-pushed the joshthoward/migrations-in-miniflare branch from 2771c0a to c00f6f4 Compare September 12, 2024 01:39
@joshthoward
Copy link
Contributor Author

@penalosa I think this is ready to go. There's one failing test which seems unrelated to my change, but is only reproducible on Windows. Do we have VMs sitting around that we can validate this on?

.changeset/lovely-experts-double.md Outdated Show resolved Hide resolved
packages/miniflare/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/miniflare/package.json Outdated Show resolved Hide resolved
packages/miniflare/src/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/dev/miniflare.ts Outdated Show resolved Hide resolved
packages/wrangler/src/dev/miniflare.ts Outdated Show resolved Hide resolved
packages/wrangler/src/dev/start-server.ts Outdated Show resolved Hide resolved
@penalosa
Copy link
Contributor

penalosa commented Sep 12, 2024

This looks generally good! A couple small comments, but otherwise good to go. One question—do DOs with SQlite work in remote mode? We don't seem to be sending migrations to the remote preview system

@joshthoward joshthoward force-pushed the joshthoward/migrations-in-miniflare branch from c792972 to a53f532 Compare September 12, 2024 20:48
@joshthoward joshthoward force-pushed the joshthoward/migrations-in-miniflare branch from a53f532 to 0a1224a Compare September 12, 2024 21:05
@joshthoward joshthoward merged commit d68e8c9 into main Sep 12, 2024
21 checks passed
@joshthoward joshthoward deleted the joshthoward/migrations-in-miniflare branch September 12, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caretaking Priority for caretaking
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants