-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not including detail id in wrangler output from R2 event notifications #6671
Not including detail id in wrangler output from R2 event notifications #6671
Conversation
🦋 Changeset detectedLatest commit: db4b352 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-wrangler-6671 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6671/npm-package-wrangler-6671 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-wrangler-6671 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-create-cloudflare-6671 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-kv-asset-handler-6671 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-miniflare-6671 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-pages-shared-6671 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-vitest-pool-workers-6671 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-workers-editor-shared-6671 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-workers-shared-6671 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally good, but could you fill in the PR template? In particular, this should have a changeset.
packages/wrangler/src/r2/helpers.ts
Outdated
@@ -488,8 +488,7 @@ export async function getEventNotificationConfig( | |||
|
|||
/** Construct & transmit notification configuration to EWC. | |||
* | |||
* On success, receive HTTP 200 response with a body like: | |||
* { event_notification_detail_id: string } | |||
* On success, receive HTTP 200 response no body (originally was { event_notification_detail_id: string }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* On success, receive HTTP 200 response no body (originally was { event_notification_detail_id: string }) | |
* On success, receive HTTP 200 response with no body |
229a2f5
to
78a37bc
Compare
.changeset/smooth-bananas-obey.md
Outdated
"wrangler": patch | ||
--- | ||
|
||
feat: Update R2 Create Event Notification response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feat: Update R2 Create Event Notification response | |
fix: Update R2 Create Event Notification response |
78a37bc
to
db4b352
Compare
For posterity, we're merging this without passing status checks intentionally. It's repeatedly flaking on Windows fixtures and re-running isn't helping because it's on a fork and so Turbo caching isn't enabled. We're confident the failures are unrelated to these changes, and in any case will re-run the fixtures before releasing a version of Wrangler with this change. Approved by @lrapoport-cf |
What this PR solves / how to test
Updates the fields parsed and displayed in wrangler from the R2 Event Notification PUT payload from the Cloudflare API.
Author has addressed the following