-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(queues): Respect delivery delays during local dev #6719
Conversation
🦋 Changeset detectedLatest commit: 7aca8f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I also realized that there was a test for this bug, but the test was written incorrectly so it was passing, when it should not have been. I moved delay tests to their own file and rewrote some of them so they were accurate and tested what they claimed they were testing. |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-wrangler-6719 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6719/npm-package-wrangler-6719 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-wrangler-6719 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-create-cloudflare-6719 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-kv-asset-handler-6719 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-miniflare-6719 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-pages-shared-6719 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-vitest-pool-workers-6719 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-workers-editor-shared-6719 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-workers-shared-6719 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
8e476e7
to
7aca8f7
Compare
return this.#producers[this.name]; | ||
return Object.values(this.#producers).find( | ||
(p) => p?.queueName === this.name | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix. Producers are keyed by the binding name, not the worker name.
LGTM! thanks for the fix |
What this PR solves / how to test
Fixes MQ-744
Author has addressed the following
@jbwcloudflare