Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(queues): Respect delivery delays during local dev #6719

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

sdnts
Copy link
Contributor

@sdnts sdnts commented Sep 14, 2024

What this PR solves / how to test

Fixes MQ-744

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: already tested in unit tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this is a bugfix

@jbwcloudflare

@sdnts sdnts requested a review from a team as a code owner September 14, 2024 19:10
Copy link

changeset-bot bot commented Sep 14, 2024

🦋 Changeset detected

Latest commit: 7aca8f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sdnts
Copy link
Contributor Author

sdnts commented Sep 14, 2024

I also realized that there was a test for this bug, but the test was written incorrectly so it was passing, when it should not have been.

I moved delay tests to their own file and rewrote some of them so they were accurate and tested what they claimed they were testing.

Copy link
Contributor

github-actions bot commented Sep 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-wrangler-6719

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6719/npm-package-wrangler-6719

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-wrangler-6719 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-create-cloudflare-6719 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-kv-asset-handler-6719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-miniflare-6719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-pages-shared-6719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-vitest-pool-workers-6719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-workers-editor-shared-6719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10865069164/npm-package-cloudflare-workers-shared-6719

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.1
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@sdnts sdnts force-pushed the siddhant/fix-queue-delays branch from 8e476e7 to 7aca8f7 Compare September 14, 2024 19:47
return this.#producers[this.name];
return Object.values(this.#producers).find(
(p) => p?.queueName === this.name
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix. Producers are keyed by the binding name, not the worker name.

@jbwcloudflare
Copy link
Contributor

LGTM! thanks for the fix

@penalosa penalosa merged commit 5b5dd95 into cloudflare:main Sep 16, 2024
20 checks passed
@sdnts sdnts deleted the siddhant/fix-queue-delays branch September 16, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants