-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve node_compat warning for v2 #6781
Conversation
🦋 Changeset detectedLatest commit: 5a6939e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-wrangler-6781 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6781/npm-package-wrangler-6781 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-wrangler-6781 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-create-cloudflare-6781 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-kv-asset-handler-6781 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-miniflare-6781 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-pages-shared-6781 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-vitest-pool-workers-6781 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-workers-editor-shared-6781 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-workers-shared-6781 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need changeset but messaging 👍
59888eb
to
7e9acfa
Compare
Looks like there is a types check problem: https://github.com/cloudflare/workers-sdk/actions/runs/11013773388/job/30582884962?pr=6781#step:5:521 |
Co-authored-by: Edmund Hung <edmund@cloudflare.com>
959f645
to
5a6939e
Compare
Pushed a fixup commit |
Thanks Edmund! |
Note: This should not be merged until Sept 23, when nodejs_compat includes nodejs_compat_v2 functionality.
What this PR solves / how to test
Fixes #6759
Author has addressed the following