-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wrangler): rename experimental_assets
to assets
#6802
Conversation
🦋 Changeset detectedLatest commit: dbe7936 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-wrangler-6802 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6802/npm-package-wrangler-6802 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-wrangler-6802 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-create-cloudflare-6802 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-kv-asset-handler-6802 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-miniflare-6802 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-pages-shared-6802 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-vitest-pool-workers-6802 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-workers-editor-shared-6802 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-workers-shared-6802 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
70cde23
to
75ef681
Compare
282f6e7
to
d19315f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending potential copy changes re: sites/legacy assets :)
so happy all the variable names are a reasonable length now 😅
45ce185
to
dda1cbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change to the deprecation message. I think I'd have reached for a capital "Assets" or "Workers Assets" (as a full name), but nbd. We can see how this lands with folks and fixup in either docs or here as we see what uptake looks like.
739448e
to
dbe7936
Compare
What this PR solves / how to test
Fixes WC-2640
Please review per commit ❤︎
Author has addressed the following