Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wrangler): rename experimental_assets to assets #6802

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Sep 23, 2024

What this PR solves / how to test

Fixes WC-2640

Please review per commit ❤︎

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation

@CarmenPopoviciu CarmenPopoviciu requested review from a team as code owners September 23, 2024 13:00
Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: dbe7936

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CarmenPopoviciu CarmenPopoviciu added the e2e Run e2e tests on a PR label Sep 23, 2024
Copy link
Contributor

github-actions bot commented Sep 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-wrangler-6802

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6802/npm-package-wrangler-6802

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-wrangler-6802 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-create-cloudflare-6802 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-kv-asset-handler-6802
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-miniflare-6802
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-pages-shared-6802
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-vitest-pool-workers-6802
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-workers-editor-shared-6802
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11012166343/npm-package-cloudflare-workers-shared-6802

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.8 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.5
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu removed the e2e Run e2e tests on a PR label Sep 23, 2024
@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner September 23, 2024 14:23
@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Sep 23, 2024
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/wa-yay branch 2 times, most recently from 282f6e7 to d19315f Compare September 23, 2024 15:36
packages/wrangler/e2e/dev.test.ts Outdated Show resolved Hide resolved
fixtures/workers-with-assets-only/wrangler.toml Outdated Show resolved Hide resolved
packages/wrangler/src/deployment-bundle/worker.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending potential copy changes re: sites/legacy assets :)

so happy all the variable names are a reasonable length now 😅

Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change to the deprecation message. I think I'd have reached for a capital "Assets" or "Workers Assets" (as a full name), but nbd. We can see how this lands with folks and fixup in either docs or here as we see what uptake looks like.

packages/wrangler/e2e/versions.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/configuration.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/configuration.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/configuration.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/configuration.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/dev.tsx Show resolved Hide resolved
packages/wrangler/src/deploy/index.ts Show resolved Hide resolved
packages/wrangler/src/deploy/index.ts Show resolved Hide resolved
packages/wrangler/src/deploy/index.ts Show resolved Hide resolved
packages/wrangler/src/config/validation.ts Outdated Show resolved Hide resolved
@edmundhung edmundhung merged commit 17eb8a9 into main Sep 24, 2024
29 checks passed
@edmundhung edmundhung deleted the carmen/wa-yay branch September 24, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants