Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: experimental Angular template using Workers with Assets was broken #6815

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Sep 24, 2024

What this PR solves / how to test

Fixes #000

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: experimental template (tested manually)
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: experimental template (tested manually)
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: undocumented experimental template

@petebacondarwin petebacondarwin requested review from a team as code owners September 24, 2024 16:02
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 9cb433e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11017663958/npm-package-wrangler-6815

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6815/npm-package-wrangler-6815

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11017663958/npm-package-wrangler-6815 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11017663958/npm-package-create-cloudflare-6815 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11017663958/npm-package-cloudflare-kv-asset-handler-6815
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11017663958/npm-package-miniflare-6815
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11017663958/npm-package-cloudflare-pages-shared-6815
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11017663958/npm-package-cloudflare-vitest-pool-workers-6815
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11017663958/npm-package-cloudflare-workers-editor-shared-6815
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11017663958/npm-package-cloudflare-workers-shared-6815

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.8 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.5
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung merged commit ffe8d10 into main Sep 24, 2024
27 of 29 checks passed
@edmundhung edmundhung deleted the fix-c3-experimental-angular-template branch September 24, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants