Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local builds of Wrangler #6870

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Fix local builds of Wrangler #6870

merged 2 commits into from
Oct 1, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Oct 1, 2024

What this PR solves / how to test

Fixes N/A

This should resolve the issue presented in #6866 (comment) with local builds of Wrangler.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: not covered by tests. This affects the bundling of Wrangler, which is not tested by any of our unit tests.
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: minor change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@penalosa penalosa requested a review from a team as a code owner October 1, 2024 11:51
Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 1625091

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11124728345/npm-package-wrangler-6870

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6870/npm-package-wrangler-6870

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11124728345/npm-package-wrangler-6870 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11124728345/npm-package-create-cloudflare-6870 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11124728345/npm-package-cloudflare-kv-asset-handler-6870
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11124728345/npm-package-miniflare-6870
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11124728345/npm-package-cloudflare-pages-shared-6870
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11124728345/npm-package-cloudflare-vitest-pool-workers-6870
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11124728345/npm-package-cloudflare-workers-editor-shared-6870
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11124728345/npm-package-cloudflare-workers-shared-6870

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.12 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.0
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit dc9039a into main Oct 1, 2024
19 of 21 checks passed
@penalosa penalosa deleted the penalosa/fix-deps branch October 1, 2024 13:55
@workers-devprod workers-devprod mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants