-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix not-deterministic log message #6885
Conversation
path list ordering
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-wrangler-6885 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6885/npm-package-wrangler-6885 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-wrangler-6885 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-create-cloudflare-6885 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-kv-asset-handler-6885 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-miniflare-6885 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-pages-shared-6885 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-vitest-pool-workers-6885 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-workers-editor-shared-6885 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11165930873/npm-package-cloudflare-workers-shared-6885 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the lists in the original snapshot were already sorted?
Yep. Ran an update snapshot run with no changes. |
What this PR solves / how to test
Fixes #0000
Sometimes caused a snapshot mismatch eg https://github.com/cloudflare/workers-sdk/actions/runs/11161082325/job/31022879309#step:5:1
Simple fix to ensure the order is deterministic
Author has addressed the following