-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pages project delete
should error if project name not specified
#6914
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-wrangler-6914 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6914/npm-package-wrangler-6914 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-wrangler-6914 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-create-cloudflare-6914 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-kv-asset-handler-6914 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-miniflare-6914 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-pages-shared-6914 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-vitest-pool-workers-6914 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-workers-editor-shared-6914 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-workers-shared-6914 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good - could we add a test to confirm?
2312e2a
to
f2d1df9
Compare
What this PR solves / how to test
Fixes #5559
To be quite honest, I have no idea why this appeases yargs and the previous state did not.
Author has addressed the following