Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pages project delete should error if project name not specified #6914

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Oct 7, 2024

What this PR solves / how to test

Fixes #5559
To be quite honest, I have no idea why this appeases yargs and the previous state did not.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: adequately covered by unit tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: trivial
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: trivial

@emily-shen emily-shen requested review from a team as code owners October 7, 2024 16:44
Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: f2d1df9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 7, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-wrangler-6914

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6914/npm-package-wrangler-6914

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-wrangler-6914 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-create-cloudflare-6914 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-kv-asset-handler-6914
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-miniflare-6914
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-pages-shared-6914
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-vitest-pool-workers-6914
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-workers-editor-shared-6914
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11251950059/npm-package-cloudflare-workers-shared-6914

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.80.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.1
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good - could we add a test to confirm?

@emily-shen emily-shen requested a review from andyjessop October 8, 2024 08:27
@emily-shen emily-shen force-pushed the emily/pages-delete-bug branch from 2312e2a to f2d1df9 Compare October 9, 2024 09:15
@emily-shen emily-shen merged commit a24c86b into main Oct 10, 2024
20 checks passed
@emily-shen emily-shen deleted the emily/pages-delete-bug branch October 10, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: wrangler pages project delete should enforce a project name argument
2 participants