Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify tsconfig templates #6957

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: simplify tsconfig templates #6957

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 14, 2024

What this PR solves / how to test

create-cloudflare generates unnecessary verbose tsconfig.json.

I think it would be better to generate simpler configs not to confuse out users - simpler is better!

The current tsconfig.json templates are probably derived from tsc --init which does not make a lot of sense because they would be different for different version of TypeScript.

Fixes N/A.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: Remove commented out code in templates
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: No functional changes

@vicb vicb added the e2e Run e2e tests on a PR label Oct 14, 2024
@vicb vicb requested review from a team as code owners October 14, 2024 07:06
Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 78e30cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11322600793/npm-package-wrangler-6957

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6957/npm-package-wrangler-6957

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11322600793/npm-package-wrangler-6957 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11322600793/npm-package-create-cloudflare-6957 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11322600793/npm-package-cloudflare-kv-asset-handler-6957
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11322600793/npm-package-miniflare-6957
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11322600793/npm-package-cloudflare-pages-shared-6957
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11322600793/npm-package-cloudflare-vitest-pool-workers-6957
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11322600793/npm-package-cloudflare-workers-editor-shared-6957
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11322600793/npm-package-cloudflare-workers-shared-6957

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.80.4 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241004.0
workerd 1.20241004.0 1.20241004.0
workerd --version 1.20241004.0 2024-10-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@vicb vicb mentioned this pull request Oct 14, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant