feat(worker-playground): delay preview environment setup #6962
Conversation
🦋 Changeset detectedLatest commit: 30f8387 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11327229098/npm-package-wrangler-6962You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6962/npm-package-wrangler-6962Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11327229098/npm-package-wrangler-6962 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11327229098/npm-package-create-cloudflare-6962 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11327229098/npm-package-cloudflare-kv-asset-handler-6962npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11327229098/npm-package-miniflare-6962npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11327229098/npm-package-cloudflare-pages-shared-6962npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11327229098/npm-package-cloudflare-vitest-pool-workers-6962npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11327229098/npm-package-cloudflare-workers-editor-shared-6962npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11327229098/npm-package-cloudflare-workers-shared-6962Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
| preview(); | ||
|
|
||
| if (url === previewUrl) { | ||
| setRefreshTimestamp(new Date().toISOString()); |
There was a problem hiding this comment.
The timestamp has no use but trigger the effect above (sendRequest) to re-run.
| const [url, setUrl] = useState(previewUrl); | ||
| const [refreshTimestamp, setRefreshTimestamp] = useState<string>(); | ||
|
|
||
| const hasBody = method !== "HEAD" && method !== "GET" && method !== "OPTIONS"; | ||
| useEffect(() => { | ||
| setUrl(previewUrl); | ||
| }, [previewUrl]); |
There was a problem hiding this comment.
We need an additional url state to load if the url is changed on submit. This is useful to decide whether we need to re-fetch the response from the same url.
| }, | ||
| [previewHash, setPreviewUrl, previewUrl, method, headers, hasBody, body] | ||
| ); | ||
| const ensureDevtoolsConnected = useRef(false); |
There was a problem hiding this comment.
Why has this been deleted?
There was a problem hiding this comment.
The variable ensureDevtoolsConnected was used to send the initial request. This is no longer needed as we have the useEffect to keep track of all the config and send a new request when needed.
There was a problem hiding this comment.
Why did this file need changed? It seems from a quick skim that it's doing roughly the same thing
There was a problem hiding this comment.
We didn't share the URLBar implementation between the two tabs unlike the dashboard. Do you want me to fix that?
penalosa
added
the
preview:workers-playground
What this PR solves / how to test
Fixes DEVX-1410.
Author has addressed the following