-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional output fields to pages deployments #6990
Add additional output fields to pages deployments #6990
Conversation
🦋 Changeset detectedLatest commit: 9724518 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11369247844/npm-package-wrangler-6990 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6990/npm-package-wrangler-6990 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11369247844/npm-package-wrangler-6990 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11369247844/npm-package-create-cloudflare-6990 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11369247844/npm-package-cloudflare-kv-asset-handler-6990 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11369247844/npm-package-miniflare-6990 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11369247844/npm-package-cloudflare-pages-shared-6990 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11369247844/npm-package-cloudflare-vitest-pool-workers-6990 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11369247844/npm-package-cloudflare-workers-editor-shared-6990 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11369247844/npm-package-cloudflare-workers-shared-6990 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @courtney-sims.
You'll need a changeset and some tests. See https://github.com/cloudflare/workers-sdk/blob/09b50927a62731f8aa621b9d872d10d1900a60a5/packages/wrangler/src/__tests__/output.test.ts
But also I think it might be safest if you create a new OutputEntry, rather than updating a current one. These entries are a contract between Wrangler and other tools that have an expectation of what is in the entry. Although this is adding new fields so would probably not break a downstream client of the output, you might have a situation where a client expects fields to be there which are not?
Either way, I think that the wrangler-action would need to ensure that the version of Wranger being used was new enough that this output included these fields.
7459b44
to
b76f463
Compare
5528699
to
9724518
Compare
What this PR solves / how to test
cloudflare/wrangler-action#300
Adds additional outputs to wrangler's artifact mechanism for pages deploys. This allows wrangler-action to pull from wrangler's artifacts to get info about pages deploys, adding parity to the outputs pages-action provides.
Test by installing the wrangler prerelease in a local pages project, setting WRANGLER_OUTPUT_FILE_DIRECTORY in the local environment, running a pages deploy, and checking the output file.
Author has addressed the following