Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dev registry messaging #7172

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Nov 5, 2024

Cleans up & clarifies dev registry messaging (mostly in response to #7009 (comment)) cc @isaac-mcfadyen

  • Shift from inscrutable red & green dots to connected/not connected with an explanation logged the first time
Screenshot 2024-11-05 at 13 50 49
  • Remove the "Live workers" warning in local mode, where it doesn't apply

@penalosa penalosa requested a review from a team as a code owner November 5, 2024 13:52
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: a265abf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-wrangler-7172

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7172/npm-package-wrangler-7172

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-wrangler-7172 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-create-cloudflare-7172 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-cloudflare-kv-asset-handler-7172
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-miniflare-7172
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-cloudflare-pages-shared-7172
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-cloudflare-vitest-pool-workers-7172
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-cloudflare-workers-editor-shared-7172
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-cloudflare-workers-shared-7172
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11710734650/npm-package-cloudflare-workflows-shared-7172

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.85.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung
Copy link
Member

edmundhung commented Nov 6, 2024

Why do we need the concept of connected here? Shouldn't we just make it an error if it is not connected?

@penalosa
Copy link
Contributor Author

penalosa commented Nov 6, 2024

Why do we need the concept of connected here? Shouldn't we just make it an error if it is not connected?

I'm not sure I understand what you mean here—what should be an error?

@isaac-mcfadyen
Copy link
Contributor

Cleans up & clarifies dev registry messaging (mostly in response to #7009 (comment)) cc @isaac-mcfadyen

Awesome, thank you @penalosa! 😄

@penalosa penalosa merged commit 3dce388 into main Nov 7, 2024
22 checks passed
@penalosa penalosa deleted the penalosa/cleanup-dev-registry-messaging branch November 7, 2024 13:04
@workers-devprod workers-devprod mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants