Separate config for preview_urls

[taylorlee]

Fixes WC-2914

Add preview_urls toggle to wrangler.toml

The current Preview URLs (beta) feature routes to version preview urls based on the status of the workers_dev config value. Beta users have requested the ability to enable deployment urls and preview urls separately on workers.dev, and the new previews_enabled field of the enable-subdomain API will allow that. This change separates the workers_dev and workers_dev_previews behavior during wrangler triggers deploy and wrangler versions upload. wrangler_dev_previews defaults to true, and does not implicitly depend on routes the way wrangler_dev does.

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because: workflows does not have them
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s): [Workers] Preview URL updates cloudflare-docs#18173
  • Documentation not necessary because: no modifications to the feature usage

[changeset-bot]

🦋 Changeset detected

Latest commit: a0c2336

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[taylorlee]

I kept this unchanged (aside from unrolling the conditional branches for easier context readability), but I don't think this branch makes sense anymore.

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-wrangler-7227

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7227/npm-package-wrangler-7227

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-wrangler-7227 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-create-cloudflare-7227 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-cloudflare-kv-asset-handler-7227

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-miniflare-7227

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-cloudflare-pages-shared-7227

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-cloudflare-vitest-pool-workers-7227

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-cloudflare-workers-editor-shared-7227

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-cloudflare-workers-shared-7227

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12030227543/npm-package-cloudflare-workflows-shared-7227

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.90.0 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20241106.1
workerd	1.20241106.1	1.20241106.1
workerd --version	1.20241106.1	2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[penalosa]

Sorry to bikeshed on this, but I'm not sure about the name here. I know previews are always on workers.dev for now, but I imagine at some point in the future we might want to support previews on a custom domain/zone the user controls? Is there any reason we can't call this something like worker_previews or preview_urls?

[taylorlee]

Sorry to bikeshed on this, but I'm not sure about the name here. I know previews are always on workers.dev for now, but I imagine at some point in the future we might want to support previews on a custom domain/zone the user controls? Is there any reason we can't call this something like worker_previews or preview_urls?

Definitely open to change! Any of worker_previews, preview_urls, or worker_preview_urls seems reasonable to me. What is your preference?

[korinne]

After a quick chat with everyone, we decided preview_urls works best. Thanks @penalosa and @taylorlee!