Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WfP Assets support #7448

Merged
merged 2 commits into from
Dec 6, 2024
Merged

WfP Assets support #7448

merged 2 commits into from
Dec 6, 2024

Conversation

GregBrimble
Copy link
Contributor

@GregBrimble GregBrimble commented Dec 5, 2024

Fixes WC-2971.

Allows Workers for Platforms scripts to bring along static assets.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: will follow up with related docs soon. This PR doesn't introduce new commands or options that need immediate documentation.

@GregBrimble GregBrimble added the blocked Blocked on other work label Dec 5, 2024
@GregBrimble GregBrimble requested a review from a team as a code owner December 5, 2024 05:16
Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 8fc0d47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-wrangler-7448

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7448/npm-package-wrangler-7448

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-wrangler-7448 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-create-cloudflare-7448 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-cloudflare-kv-asset-handler-7448
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-miniflare-7448
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-cloudflare-pages-shared-7448
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-cloudflare-vitest-pool-workers-7448
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-cloudflare-workers-editor-shared-7448
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-cloudflare-workers-shared-7448
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12192836536/npm-package-cloudflare-workflows-shared-7448

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️

@GregBrimble GregBrimble added e2e Run e2e tests on a PR and removed blocked Blocked on other work labels Dec 6, 2024
@GregBrimble GregBrimble force-pushed the wfp-assets branch 6 times, most recently from 34bba50 to fe8d3c4 Compare December 6, 2024 03:31
@GregBrimble GregBrimble force-pushed the wfp-assets branch 4 times, most recently from ce496a0 to fb529cb Compare December 6, 2024 04:05
@penalosa penalosa merged commit 20a0f17 into main Dec 6, 2024
31 of 32 checks passed
@penalosa penalosa deleted the wfp-assets branch December 6, 2024 11:42
@workers-devprod workers-devprod mentioned this pull request Dec 6, 2024
penalosa pushed a commit that referenced this pull request Jan 10, 2025
* WfP Assets support

* Add e2e test for WfP & Assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants