Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: extend the timeout on BundleController.test.ts "custom build" test to reduce CI flakiness #7473

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Dec 6, 2024

This test keeps timing out in CI, which is just infuriating. So hopefully doubling the timeout will make it better.

E.g. https://github.com/cloudflare/workers-sdk/actions/runs/12191905934/job/34011610082?pr=7439#step:5:968

@petebacondarwin petebacondarwin added the skip-pr-description-validation Skip validation of the required PR description format label Dec 6, 2024
@petebacondarwin petebacondarwin requested a review from a team as a code owner December 6, 2024 09:33
Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: ff96608

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-wrangler-7473

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7473/npm-package-wrangler-7473

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-wrangler-7473 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-create-cloudflare-7473 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-cloudflare-kv-asset-handler-7473
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-miniflare-7473
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-cloudflare-pages-shared-7473
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-cloudflare-vitest-pool-workers-7473
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-cloudflare-workers-editor-shared-7473
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-cloudflare-workers-shared-7473
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12196387940/npm-package-cloudflare-workflows-shared-7473

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit b9d4d5a into main Dec 6, 2024
47 of 52 checks passed
@penalosa penalosa deleted the pbd/extend-timeout-for-bundle-controller-test branch December 6, 2024 11:43
penalosa pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changeset-required skip-pr-description-validation Skip validation of the required PR description format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants