Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for smart placement w/assets #7568

Merged

Conversation

WillTaylorDev
Copy link
Contributor

@WillTaylorDev WillTaylorDev commented Dec 16, 2024

Fixes #0000

Provides a warning if using smart placement. Internal discussions still ongoing on whether to hard block on this instead of warn.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 3c6ad5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/expirimental_serve_directly_smart_placement branch 2 times, most recently from 8312438 to 529b021 Compare December 16, 2024 21:38
@WillTaylorDev
Copy link
Contributor Author

Smart placement docs here:
cloudflare/cloudflare-docs#18780

Copy link
Contributor

github-actions bot commented Dec 16, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-wrangler-7568

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7568/npm-package-wrangler-7568

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-wrangler-7568 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-workers-bindings-extension-7568 -O ./cloudflare-workers-bindings-extension.0.0.0-v5b7349de4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v5b7349de4.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-create-cloudflare-7568 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-kv-asset-handler-7568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-miniflare-7568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-pages-shared-7568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-unenv-preset-7568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-vitest-pool-workers-7568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-workers-editor-shared-7568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-workers-shared-7568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414037279/npm-package-cloudflare-workflows-shared-7568

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.98.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@Skye-31 Skye-31 changed the title Add warning for smart placement Add warning for smart placement w/assets Dec 16, 2024
@CarmenPopoviciu CarmenPopoviciu added the blocked Blocked on other work label Dec 17, 2024
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/experimental_serve_directly-validation branch 2 times, most recently from 21f93eb to c826454 Compare December 17, 2024 14:42
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/expirimental_serve_directly_smart_placement branch 2 times, most recently from b4df55e to abb9de8 Compare December 18, 2024 18:05
@WillTaylorDev WillTaylorDev marked this pull request as ready for review December 18, 2024 18:06
@WillTaylorDev WillTaylorDev requested a review from a team as a code owner December 18, 2024 18:06
@WillTaylorDev
Copy link
Contributor Author

  • Needs changeset
  • Needs to merge smartplacement docs first
  • Need to wait until target branch is merged to main

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/experimental_serve_directly-validation branch from c826454 to ab124d9 Compare December 18, 2024 21:22
@CarmenPopoviciu CarmenPopoviciu force-pushed the willtaylor/experimental_serve_directly-validation branch from bd1116d to 95e00b2 Compare December 19, 2024 09:19
@CarmenPopoviciu CarmenPopoviciu requested review from a team as code owners December 19, 2024 09:19
@CarmenPopoviciu CarmenPopoviciu force-pushed the willtaylor/experimental_serve_directly-validation branch 2 times, most recently from ee587cf to 3ce560e Compare December 19, 2024 09:23
Base automatically changed from willtaylor/experimental_serve_directly-validation to main December 19, 2024 10:09
@CarmenPopoviciu CarmenPopoviciu force-pushed the willtaylor/expirimental_serve_directly_smart_placement branch from 469ece6 to f5c081f Compare December 19, 2024 12:27
@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Dec 19, 2024
@CarmenPopoviciu CarmenPopoviciu force-pushed the willtaylor/expirimental_serve_directly_smart_placement branch 2 times, most recently from 469ece6 to 79c1528 Compare December 19, 2024 12:32
@CarmenPopoviciu CarmenPopoviciu force-pushed the willtaylor/expirimental_serve_directly_smart_placement branch from 79c1528 to 7a6a79d Compare December 19, 2024 13:46
@CarmenPopoviciu CarmenPopoviciu removed the blocked Blocked on other work label Dec 19, 2024
@CarmenPopoviciu CarmenPopoviciu force-pushed the willtaylor/expirimental_serve_directly_smart_placement branch from 7a6a79d to 3c6ad5e Compare December 19, 2024 13:52
@CarmenPopoviciu CarmenPopoviciu merged commit 2bbcb93 into main Dec 19, 2024
31 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the willtaylor/expirimental_serve_directly_smart_placement branch December 19, 2024 14:59
penalosa pushed a commit that referenced this pull request Jan 10, 2025
* Provide validation around experimental_serve_directly usage in dev and deploy

* Update based on PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants