remove functions that are removed from node:util #7942

anonrig · 2025-01-28T15:54:42Z

Removes methods that are removed from node.js

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: they are removed from node.js
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: removing deprecated/removed functions
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: they're removed from node.js

changeset-bot · 2025-01-28T15:54:51Z

🦋 Changeset detected

Latest commit: 58f34f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/unenv-preset	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/lazy-oranges-jump.md

Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>

github-actions · 2025-01-28T16:27:33Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-wrangler-7942

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7942/npm-package-wrangler-7942

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-wrangler-7942 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-cloudflare-workers-bindings-extension-7942 -O ./cloudflare-workers-bindings-extension.0.0.0-v7f7716a6d.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v7f7716a6d.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-create-cloudflare-7942 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-cloudflare-kv-asset-handler-7942

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-miniflare-7942

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-cloudflare-pages-shared-7942

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-cloudflare-unenv-preset-7942

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-cloudflare-vite-plugin-7942

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-cloudflare-vitest-pool-workers-7942

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-cloudflare-workers-editor-shared-7942

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-cloudflare-workers-shared-7942

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014632501/npm-package-cloudflare-workflows-shared-7942

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.106.0 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20250124.0
`workerd`	1.20250124.0	1.20250124.0
`workerd --version`	1.20250124.0	2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Cherry · 2025-01-28T16:32:19Z

Is there a documented backwards compatibility strategy for nodejs_compat? If I have a worker in production with this:

import { isNumber } from 'node:util';

export default {
	async fetch(request, env, ctx): Promise<Response> {
		const bar = Math.random() > 0.5 ? 1 : 'foo';
		if (isNumber(bar)) {
			return new Response('Number!');
		}
		return new Response('Hello World!');
	},
} satisfies ExportedHandler<Env>;

which works completely fine with nodejs_compat, will it break after this lands in the latest version of wrangler and I go to redeploy? In the latest version of Node.js 22, util.isNumber('cd') works without issue, though is indeed marked as deprecated.

vicb

Let's wait before merging this...

2 reasons:

First use the preset in this repo matching unenv and start diverging later
We have at least one user telling us he is using the API

Idea: maybe we can add a flag (--disable-node-deprecated-apis-v18) or something.

(Requesting changes to make sure this doesn't get in too early)

anonrig · 2025-01-28T16:58:45Z

which works completely fine with nodejs_compat, will it break after this lands in the latest version of wrangler and I go to redeploy? In the latest version of Node.js 22, util.isNumber('cd') works without issue, though is indeed marked as deprecated.

You will not have any issues when you redeploy. If you use a specific version of wrangler it will always come with the polyfill. On another hand, if you update wrangler, then you'll just see that isNumber doesn't exist anymore.

These functions are removed on April 29, 2024: nodejs/node#52744

Cherry · 2025-01-28T17:01:46Z

You will not have any issues when you redeploy. If you use a specific version of wrangler it will always come with the polyfill. On another hand, if you update wrangler, then you'll just see that isNumber doesn't exist anymore.

These functions are removed on April 29, 2024: nodejs/node#52744

If I'm understanding correctly, these will be removed in Node.js 23, and therefore any future versions as well. This makes sense as it's a new major version bump, and breaking changes are expected.

wrangler / nodejs_compat wouldn't have that here, so expecting these functions to disappear in a minor version would not be a great DX. This is why I was asking primarily if there was a documented strategy around nodejs_compat versioning and backwards compatibility.

jasnell · 2025-01-28T17:06:12Z

hmmm... I think we need to carefully think about this. If these were implemented in the runtime we would need to keep them around forever with or without a compatibility flag. I think breaking changes in polyfill implementations that we choose to bundle are fundamentally different from ones that the user chooses to bundle and the burden of support is significantly higher.

Instead of removing these like this, it would likely be a much better idea to noisily deprecate them for a few versions of wrangler, detecting when they are used and complaining loudly for a while before dropping them.

petebacondarwin · 2025-01-29T08:37:09Z

@Cherry makes a good point. This is actually a breaking change to Wrangler so should be rolled out in v4?

petebacondarwin

Let's hold on this removal and follow the path suggested by @vicb.

vicb · 2025-01-31T19:52:47Z

packages/unenv-preset/src/runtime/node/util/index.ts

 	getSystemErrorMap,
 	getSystemErrorName,
-	isArray,


Note: isArray is not removed from Node and the timeline to remove the other functions is Node 23.

isArray is available and implemented on workerd

I should have commented on l94 instead.
What I meant is that isArray is not part of the functions removed in Node23.

But if we have some of the functions here implemented in workerd (and not going away) we should definitely use the workerd version instead - I guess it will be a different PR.

Thanks

anonrig requested review from petebacondarwin and vicb January 28, 2025 15:54

anonrig requested review from a team as code owners January 28, 2025 15:54

remove removed functions from node:util polyfills

42bbdaa

anonrig force-pushed the yagiz/remove-removed-util-methods branch from ee2e57c to 42bbdaa Compare January 28, 2025 15:55

anonrig changed the title ~~remove removed functions from node:util polyfills~~ remove functions that are removed from node:util Jan 28, 2025

anonrig mentioned this pull request Jan 28, 2025

add missing node:util methods cloudflare/workerd#3418

Merged

petebacondarwin approved these changes Jan 28, 2025

View reviewed changes

.changeset/lazy-oranges-jump.md Show resolved Hide resolved

Update .changeset/lazy-oranges-jump.md

58f34f3

Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>

vicb requested changes Jan 28, 2025

View reviewed changes

petebacondarwin added the breaking change Change that will result in breaking existing behavior label Jan 29, 2025

petebacondarwin marked this pull request as draft January 29, 2025 08:37

petebacondarwin requested changes Jan 29, 2025

View reviewed changes

vicb reviewed Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove functions that are removed from node:util #7942

remove functions that are removed from node:util #7942

anonrig commented Jan 28, 2025

changeset-bot bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

Cherry commented Jan 28, 2025 •

edited

Loading

vicb left a comment

anonrig commented Jan 28, 2025 •

edited

Loading

Cherry commented Jan 28, 2025

jasnell commented Jan 28, 2025

petebacondarwin commented Jan 29, 2025

petebacondarwin left a comment

vicb Jan 31, 2025

anonrig Jan 31, 2025

vicb Feb 1, 2025

remove functions that are removed from node:util #7942

Are you sure you want to change the base?

remove functions that are removed from node:util #7942

Conversation

anonrig commented Jan 28, 2025

changeset-bot bot commented Jan 28, 2025 • edited Loading

🦋 Changeset detected

github-actions bot commented Jan 28, 2025 • edited Loading

Cherry commented Jan 28, 2025 • edited Loading

vicb left a comment

Choose a reason for hiding this comment

anonrig commented Jan 28, 2025 • edited Loading

Cherry commented Jan 28, 2025

jasnell commented Jan 28, 2025

petebacondarwin commented Jan 29, 2025

petebacondarwin left a comment

Choose a reason for hiding this comment

vicb Jan 31, 2025

Choose a reason for hiding this comment

anonrig Jan 31, 2025

Choose a reason for hiding this comment

vicb Feb 1, 2025

Choose a reason for hiding this comment

changeset-bot bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

Cherry commented Jan 28, 2025 •

edited

Loading

anonrig commented Jan 28, 2025 •

edited

Loading