-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for reading build time env variables from a .env
file
#882
feat: add support for reading build time env variables from a .env
file
#882
Conversation
🦋 Changeset detectedLatest commit: db77991 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2269865880/npm-package-wrangler-882 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/882/npm-package-wrangler-882 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2269865880/npm-package-wrangler-882 dev path/to/script.js |
16555d2
to
e27122b
Compare
This looks good. Open it for review so I can stamp and we'll land it? |
I think I have broken the tests on Ubuntu. So I will wait till tomorrow before marking it ready. |
I cancelled the workflow, it was at 45 mins, and would eat up through our minutes haha. |
4993708
to
7d22718
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of nits, but otherwise looks good! shipit
…file This change will automatically load up a `.env` file, if found, and apply its values to the current environment. An example would be to provide a specific CLOUDFLARE_ACCOUNT_ID value. Related to cloudflare#190
7d22718
to
db77991
Compare
This change will automatically load up a
.env
file, if found, and apply itsvalues to the current environment. An example would be to provide a specific
CLOUDFLARE_ACCOUNT_ID value.
Related to #190