Add parity with pages-action for Pages deploy outputs #303
+235
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtney-sims
commented
Oct 18, 2024
courtney-sims
force-pushed
the
courtney-sims-enable-outputs
branch
from
73da4bd
to
f6d8d23
Compare
Maximo-Guk
reviewed
Oct 18, 2024
Maximo-Guk
reviewed
Oct 18, 2024
courtney-sims
force-pushed
the
courtney-sims-enable-outputs
branch
3 times, most recently
from
1d56fe8
to
62ce1c3
Compare
Maximo-Guk
reviewed
Oct 21, 2024
courtney-sims
force-pushed
the
courtney-sims-enable-outputs
branch
from
983a2cd
to
03dd701
Compare
courtney-sims
force-pushed
the
courtney-sims-enable-outputs
branch
from
03dd701
to
ee43009
Compare
Maximo-Guk
approved these changes
Oct 22, 2024
Maximo-Guk
reviewed
Oct 22, 2024
| } from "./wranglerArtifactManager"; | ||
|
|
||
| describe("wranglerArtifactsManager", () => { | ||
| const mock = require("mock-fs"); |
There was a problem hiding this comment.
We should probably be using an es6 style import here
Maximo-Guk
reviewed
Oct 22, 2024
| expect(artifacts).toEqual([ | ||
| "./testOutputDir/wrangler-output-2024-10-17_18-48-40_463-2e6e83.json", | ||
| ]); | ||
| mock.restore(); |
There was a problem hiding this comment.
We could probably move mock.restore() in to an afterEach()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables Pages deploys to provide outputs for id, environment, url, and alias, just like they can in pages-action. The current way of getting deploy outputs with Workers is via wrangler output to std out, but this information for Pages was not available in std out.
Because of that, this change adds a new method for getting outputs via wrangler artifacts.
The new outputs look like this in the Actions view.
When an alias is not available in the artifact:
When an alias is available in the artifact:
When we don't get stuff back from the request for artifact:
