Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove d1 local hardcoding #2248

Merged
merged 2 commits into from
Nov 21, 2022
Merged

chore: remove d1 local hardcoding #2248

merged 2 commits into from
Nov 21, 2022

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Nov 21, 2022

Closes #2189

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2022

🦋 Changeset detected

Latest commit: bb1ddcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3513737193/npm-package-wrangler-2248

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2248/npm-package-wrangler-2248

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3513737193/npm-package-wrangler-2248 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.developers.workers.dev/runs/3513737193/npm-package-cloudflare-pages-shared-2248

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #2248 (bb1ddcb) into main (ef24dba) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2248      +/-   ##
==========================================
+ Coverage   71.76%   71.77%   +0.01%     
==========================================
  Files         145      145              
  Lines        9474     9474              
  Branches     2470     2470              
==========================================
+ Hits         6799     6800       +1     
+ Misses       2675     2674       -1     
Impacted Files Coverage Δ
packages/wrangler/src/dev/start-server.ts 62.82% <ø> (ø)
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@GregBrimble
Copy link
Member

Changeset maybe?

@rozenmd rozenmd merged commit effc221 into main Nov 21, 2022
@rozenmd rozenmd deleted the remove-d1-local-hardcoding branch November 21, 2022 11:13
@github-actions github-actions bot mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Fix d1 remote mode
2 participants