Skip to content

Commit

Permalink
Merge pull request #10 from whdalsrnt/master
Browse files Browse the repository at this point in the history
Change expiration time when downloading files
  • Loading branch information
whdalsrnt authored Sep 9, 2024
2 parents 508816a + 43ad86d commit 2598a32
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
### Category
- [ ] New feature
- [ ] Bug fix
- [ ] Improvement
- [ ] Refactor
- [ ] etc

### Description

### Known issue
2 changes: 1 addition & 1 deletion src/spaceone/file_manager/connector/aws_s3_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def get_upload_url(self, file_id, file_name):
def get_download_url(self, file_id, file_name):
object_name = self._generate_object_name(file_id, file_name)
response = self.client.generate_presigned_url(
"get_object", Params={"Bucket": self.bucket_name, "Key": object_name}
"get_object", Params={"Bucket": self.bucket_name, "Key": object_name}, ExpiresIn=86400
)

return response
Expand Down

0 comments on commit 2598a32

Please sign in to comment.