Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor type error #3

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix minor type error #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ __pycache__
venv
local-conf.yml
.DS_Store
yaml
1 change: 1 addition & 0 deletions pkg/pip_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
spaceone-api
pre-commit
python3-saml
requests
2 changes: 1 addition & 1 deletion src/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.0.1
0.0.0
3 changes: 2 additions & 1 deletion src/plugin/connector/saml_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import logging
import xml.etree.ElementTree as ET
from typing import Tuple

import requests
from onelogin.saml2.auth import OneLogin_Saml2_Auth
Expand Down Expand Up @@ -150,7 +151,7 @@ def _fetch_xml(metadata_url: str) -> bytes:
raise ERROR_NOT_FOUND(message=f"ERROR_NOT_FOUND: {e}")

@staticmethod
def _parse_xml(xml_data: bytes) -> tuple[str, str, str]:
def _parse_xml(xml_data: bytes) -> Tuple[str, str, str]:
"""Parses the XML data to extract entity ID, x509 certificate, and SSO URL.

Args:
Expand Down
Loading