Skip to content
This repository has been archived by the owner on Feb 10, 2022. It is now read-only.

Support metrics endpoint #8

Closed
making opened this issue Sep 7, 2018 · 6 comments · Fixed by #9
Closed

Support metrics endpoint #8

making opened this issue Sep 7, 2018 · 6 comments · Fixed by #9
Assignees
Labels
accepted enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@making
Copy link
Contributor

making commented Sep 7, 2018

https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/monitoring.md#metrics-endpoint
It would be great if metrics endpoint flag is enabled and etcd can be monitored by prometheus-bosh-release.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/160352833

The labels on this github issue will be updated when the story is started.

@alex-slynko
Copy link
Member

Hi @making

This idea definitely makes sense. Please send us the PR to allow us optionally enable this flag and we will merge it.

@alex-slynko alex-slynko added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed unscheduled labels Sep 11, 2018
@making
Copy link
Contributor Author

making commented Sep 12, 2018

Sorry, I misunderstood. The endpoint has been already enabled.
I was able to access /metrics

curl --cert /var/vcap/jobs/etcd/config/etcd.crt --key /var/vcap/jobs/etcd/config/etcd.key --cacert /var/vcap/jobs/etcd/config/etcd-ca.crt -k -v https://localhost:2379/metrics

@making making closed this as completed Sep 12, 2018
@alex-slynko
Copy link
Member

Hi @making

I would like to mention that etcd 3.3 allows operator to specify custom property to disable authentication from /metrics endpoint etcd-io/etcd#8060

This property is not exposed yet. I thought you meant exposing it. We will accept PR for exposing this optionally, so the operator can choose the best thing for their environment.

@making
Copy link
Contributor Author

making commented Sep 12, 2018

Ok, I'll make a pr to expose --listen-metrics-urls.
Is there any policy to test the change?

@making making reopened this Sep 12, 2018
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/160460856

The labels on this github issue will be updated when the story is started.

making added a commit to making/cfcr-etcd-release that referenced this issue Sep 12, 2018
making added a commit to making/cfcr-etcd-release that referenced this issue Sep 12, 2018
@SemanticallyNull SemanticallyNull self-assigned this Sep 13, 2018
leeloodub pushed a commit to vmware-archive/pks-cfcr-etcd-release that referenced this issue Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants