This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
fix: CCDB secret rotation: set explicit resource limits #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were failing in CI when attempting to rotate the CCDB keys; this turns out to be because were were getting OOMKilled. It appears that the job needs more than 128Mi to complete (as in, 192Mi appears to work; intermediate values were not tested). Set the limits for the process explicitly to hopefully fix CI.
The CCDB database key rotation job is a single-purpose job that doesn't require a log sidecar, as only one container has meaningful output, and it's not long-running.
jandubois
previously approved these changes
Oct 1, 2020
viovanov
previously approved these changes
Oct 1, 2020
jandubois
previously approved these changes
Oct 1, 2020
viovanov
previously approved these changes
Oct 1, 2020
jandubois
approved these changes
Oct 2, 2020
fargozhu
added
changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set a memory limit on the CCDB key rotation job, so that it has enough resources to run.
From experimenting locally on a minikube:
So I'm picking a request of 192Mi, and a limit of 512Mi just in case (it should never get that high anyway).
I'm also disabling the log sidecar for that job, since it's a job and having the sidecar just means it'll never complete.
Motivation and Context
CI was failing. Not sure @viovanov ever filed a bug on it.
How Has This Been Tested?
Ran the job locally (manually triggering the QJob) until it passed.
Types of changes
Checklist: