This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
feat: chart: add labels to QuarksStatefulSets #1455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the standard labels to the generated QuarksStatefulSets, so that we can see the version when examining a live deployment easier. The selector are unaffected, as we want to be able to use the previous version for a bit during an upgrade.
Motivation and Context
When examining an upgrade, it is difficult to figure out what version of KubeCF corresponds to each pod.
How Has This Been Tested?
Deployed during an upgrade (HA). I have confirmed that:
api-1
is upgraded and ready beforeapi-0
is upgraded.(Actually, the upgrade never completes because
api-1
is not counted for bootstrap, so DB migration never takes place, and thereforeapi-1
can never get ready. But that's an existing issue outside this PR.)Types of changes
Checklist: