This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
refactor!: make database a singleton #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use the full labels (including the version) for the selector for the database.
BREAKING CHANGE: Maintaining the database integrity while doing Galera replication is currently not feasible in k8s as part of KubeCF. The general recommendation for doing HA database is to use an external database that supports this setup. Signed-off-by: Thulio Ferraz Assis <thulio.assis@suse.com>
Co-authored-by: Mark Yen <3977982+mook-as@users.noreply.github.com>
Signed-off-by: Thulio Ferraz Assis <thulio.assis@suse.com>
mook-as
suggested changes
Oct 7, 2020
|
Is it safe to downgrade the database from HA to SA when upgrading kubecf? If not, then maybe the "unsupported" error should include some guidance to scale down the database before upgrading? (Assuming that is safe; or can that too still lead to data loss?) |
@jandubois Going from HA to SA should be safe if the active replica is the |
Co-authored-by: Mark Yen <3977982+mook-as@users.noreply.github.com>
|
@f0rmiga afaik it will always scale to the 0 ordinal |
viovanov
approved these changes
Oct 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the possibility of doing HA with the PXC database provided as part of KubeCF. It's currently not feasible to maintain a reliable HA setup as part of KubeCF.
Motivation and Context
When the active node doing writes is terminated in the middle of replication (e.g. going from SA to HA as part of an upgrade), the data is left broken.
How Has This Been Tested?
Locally. CI.
Types of changes
Checklist: