This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
fix: disable routing api under eirini, not supported #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
suggested changes
Oct 8, 2020
- Flag defaults to null now - Feature handling sets proper default per chosen scheduler - Reject user trying to force things - Values schema updated - Image lister has to skip the forbidden permutation.
andreas-kupries
force-pushed
the
ak-kubecf-1371-routing
branch
from
bc4fa2c
to
6744838
Compare
jandubois
approved these changes
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
routing_api.enabledflag defaults tonilnow.eirini+routing_api.nilfor the enabled flag)image_list.rbscript skips the forbidden permutation.Motivation and Context
See #1371 and discussion in #1445
How Has This Been Tested?
Local minikube
Types of changes
Checklist: