This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
fix: Remove blobstore settings from eirini-helm ops file #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These settings are not needed, and they will break when kubecf is configured to use an external blobstore because then the singleton-blobstore service doesn't even exist. I suspect that more settings in this file are redundant, but want to have a minimal change to just fix Eirini with external blobstore deployment.
jandubois
changed the title
fargozhu
added
changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These settings are not needed, and they will break when kubecf is configured to use an external blobstore because then the singleton-blobstore service doesn't even exist.
I suspect that more settings in this file are redundant, but want to have a minimal change to just fix Eirini with external
blobstore deployment.
How Has This Been Tested?
I've only tested that Eirini continues to work on minikube. I have not tried to deploy with an external blobstore, so there may still be other undiscovered issues.