This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to ingress.yaml that allow the pod selector to match the scheduler pod in KubeCF.
This is to address #1509 , where
ccf ssh
to apps does not work in cases where the ssh-proxy-public service uses a LoadBalancer instead of an nginx ingress-controller.Description
The scheduler pod has a label called
app.kubernetes.io/component=scheduler
Whereas the service resource described in ingress.yaml, specifies a pod selector with a value
app.kubernetes.io/component=ssh-proxy
The pull request modifies the label and the pod selector to
app.kubernetes.io/component=scheduler
, such that the service can match the ssh-proxy container in the podMotivation and Context
This change allows the ssh-proxy-public service to select the appropriate kubecf pod, and enables the
cf ssh
capability to work when the services are deployed as LoadBalanced as opposed to being exposed via an ingress-controller.Fixes #1509
How Has This Been Tested?
Deployed the charts from the pull request on AWS EKS as a backbone. (Diego deployment)
Deployed a simple cloud foundry app (python buildpack) to the deployment.
Verified that the
cf ssh
feature works by being able to ssh into the app container.Types of changes
Checklist: