Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

fix: Update ingress.yaml #1517

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

sourirv
Copy link
Contributor

@sourirv sourirv commented Oct 26, 2020

Updates to ingress.yaml that allow the pod selector to match the scheduler pod in KubeCF.
This is to address #1509 , where ccf ssh to apps does not work in cases where the ssh-proxy-public service uses a LoadBalancer instead of an nginx ingress-controller.

Description

The scheduler pod has a label called app.kubernetes.io/component=scheduler
Whereas the service resource described in ingress.yaml, specifies a pod selector with a value app.kubernetes.io/component=ssh-proxy
The pull request modifies the label and the pod selector to app.kubernetes.io/component=scheduler, such that the service can match the ssh-proxy container in the pod

Motivation and Context

This change allows the ssh-proxy-public service to select the appropriate kubecf pod, and enables the cf ssh capability to work when the services are deployed as LoadBalanced as opposed to being exposed via an ingress-controller.
Fixes #1509

How Has This Been Tested?

Deployed the charts from the pull request on AWS EKS as a backbone. (Diego deployment)
Deployed a simple cloud foundry app (python buildpack) to the deployment.
Verified that the cf ssh feature works by being able to ssh into the app container.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has security implications.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Updates to ingress.yaml that allow the pod selector to match the scheduler pod in KubeCF.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 26, 2020

CLA Check
The committers are authorized under a signed CLA.

@sourirv
Copy link
Contributor Author

sourirv commented Oct 26, 2020

@mook-as @jandubois This is the same as #1510 .

Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still fine with the change :)

Ah, the things we do to work around machines…

@jandubois jandubois changed the title Update ingress.yaml fix: Update ingress.yaml Oct 26, 2020
@jandubois jandubois merged commit 0d6c224 into cloudfoundry-incubator:master Oct 26, 2020
@fargozhu fargozhu added the changelog Issue must be present in the release notes. label Oct 27, 2020
@fargozhu fargozhu added this to the 2.6.0 milestone Oct 27, 2020
@fargozhu fargozhu removed the changelog Issue must be present in the release notes. label Oct 27, 2020
@fargozhu fargozhu removed this from the 2.6.0 milestone Oct 27, 2020
@fargozhu fargozhu modified the milestones: 2.7.0, 2.6.0 Oct 27, 2020
@fargozhu fargozhu added the changelog Issue must be present in the release notes. label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog Issue must be present in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssh-proxy-public service label fails to match a pod due to incorrect label and pod selector.
4 participants