This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
fix: Check for HA as part of estimating max app count. #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-kupries
changed the title
[gh#kubecf-1479]
andreas-kupries
force-pushed
the
ak-kubecf-1479-notes.txt
branch
from
42a2edf
to
482c789
Compare
f0rmiga
approved these changes
Nov 16, 2020
jandubois
reviewed
Nov 16, 2020
| @@ -17,7 +17,7 @@ | |||
| to monitor continuously. | |||
|
|
|||
| {{- if not .Values.features.eirini.enabled }} | |||
| {{- $cell_count := .Values.sizing.diego_cell.instances | default 1 }} | |||
| {{- $cell_count := .Values.sizing.diego_cell.instances | default (ternary 3 1 .Values.high_availability) }} | |||
There was a problem hiding this comment.
I doubt this will ever change, but instead of hard-coding the 3 you should look it up in the manifest:
{{- $_ := include "_config.lookupManifest" (list $ "instance_groups/name=diego-cell/instances") }}
{{- $cell_count := .Values.sizing.diego_cell.instances | default (ternary $.kubecf.retval 1 .Values.high_availability) }}
There was a problem hiding this comment.
Ok. Will make a follow-up PR for this.
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced fixed value of
1with a ternary returning either1or3based on the HA flag.Motivation and Context
See #1479
How Has This Been Tested?
Local minikube. Deploy only as far as needed to see the NOTES.txt in the terminal.
Types of changes
Checklist: