This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
feat: remove cc_deployment_updater. #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cc_deployment_updater job has an incorrect readiness probe; when it is in HA, it can get jammed and never become ready (see below). Rather than properly fixing it (by moving it into a separate instance group and marking it as active/passive), just drop the job completely as it does not appear to be useful at all. Details on the readiness probe problems: The probe was unaware that it was supposed to be active/passive, and just checks the logs to ensure all instances are sleeping once every five seconds. This only happened to work on passive nodes because the test incorrectly succeeded when an instance has never been ready (because jq happily accepted empty input and returned success). This means that if a pod was ever active, then turned passive again (e.g. because it was being restarted and another instance became active), it would have a stale line that matched the probe and therefore start getting marked as failed.
jandubois
approved these changes
Dec 1, 2020
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
cc_deployment_updaterjob has an incorrect readiness probe; when it is in HA, it can get jammed and never become ready (see below). Rather than properly fixing it (by moving it into a separate instance group and marking it as active/passive), just drop the job completely as it does not appear to be necessary.Motivation and Context
(Partially) fixes #1589 — we'll also want to pull in #1632 for upgrades.
How Has This Been Tested?
Finished 🐱 locally.
Types of changes
Checklist:
Additional Information:
Details on the readiness probe problems:
The probe was unaware that it was supposed to be active/passive, and just checks the logs to ensure all instances are sleeping once every five seconds. This only happened to work on passive nodes because the test incorrectly succeeded when an instance has never been ready (because
jqhappily accepted empty input and returned success). This means that if a pod was ever active, then turned passive again (e.g. because it was being restarted and another instance became active), it would have a stale line that matched the probe and therefore start getting marked as failed.