Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

fix: prevent credhub from consuming the postgres bosh-link from auto-scaler postgres #1651

Merged
merged 2 commits into from
Dec 8, 2020
Merged

fix: prevent credhub from consuming the postgres bosh-link from auto-scaler postgres #1651

merged 2 commits into from
Dec 8, 2020

Conversation

andreas-kupries
Copy link
Contributor

Description

2 changes:

  1. Disable the link via explicit nulling in the manifest. This part requires a quarks fix to work.
  2. Patch the credhub spec with a ig-resolver pre-render script to remove the link from it.

Item 2 can be removed when quarks support item 1.

Motivation and Context

See #1649

How Has This Been Tested?

Minikube deployment, kubecf with autoscaler. Checked the resolved manifest for credhub to not use the postgres database.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has security implications.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

jandubois and others added 2 commits December 7, 2020 15:21
@jandubois
fix: [gh#kubecf-1649] disable consumption of postgres bosh-link in cr…
cc23cdc 
…edhub.

This fix doesn't seem to work; most likely because quarks-operator doesn't
implement the functionality:

> Optional consumers may be specified as nil in the deployment manifest
> to block consumption of any providers.

See cloudfoundry-incubator/quarks-operator#1259

We are going to keep this change because we expect this to be fixed
in the operator eventually.
@jandubois
Remove postgres consumer annotation from credhub job
026ea33 
This avoids connecting the link to the autoscaler database
instance when that feature is enabled.

This commit is expected to be reverted when quarks-operator includes
support to disable optional link resolution via the deployment manifest
(see previous commit).
@jandubois jandubois changed the title Prevent credhub from consuming the postgres bosh-link from auto-scaler postgres fix: prevent credhub from consuming the postgres bosh-link from auto-scaler postgres Dec 7, 2020
@andreas-kupries andreas-kupries linked an issue Dec 7, 2020 that may be closed by this pull request
Clash of autoscaler bosh-link for postgres with credhub #1649
Closed
@jandubois jandubois merged commit 2963005 into master Dec 8, 2020
@jandubois jandubois deleted the ak-issue-1649-credhub-postgres branch December 8, 2020 02:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jandubois jandubois jandubois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clash of autoscaler bosh-link for postgres with credhub
2 participants
@andreas-kupries @jandubois