This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
fix: use correct secret name when credentials are overridden #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
changed the title
kubecf uses the quarks mechanism to override explicit bosh variables defined in cloudfoundry-incubator/quarks-operator#915 This works automatically for bosh variables, but not for explicit references from manually created kube objects. This PR provides a helper template to generate the proper name.
jandubois
force-pushed
the
jandubois/vars-secret-names
branch
from
a074064
to
825ca93
Compare
|
Just force-pushed this PR because I realized that the template function will work in |
mook-as
approved these changes
Jan 4, 2021
viovanov
approved these changes
Jan 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubecf uses the quarks mechanism to override explicit bosh variables defined in cloudfoundry-incubator/quarks-operator#915
This works automatically for bosh variables, but not for explicit references from manually created kube objects. This PR provides a helper template to generate the proper name.
Fixes #1666