This repository has been archived by the owner on Jul 3, 2021. It is now read-only.
Add ops-file to change etcd's metrics url #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey making! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/160486233 The labels on this github issue will be updated when the story is started. |
|
Thanks @making - I've triggered our CI pipeline to run the unit tests: https://ci.kubo.sh/teams/main/pipelines/kubo-deployment-pr/jobs/run-unit-tests/builds/25 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add an ops file to change etcd's metrics url so that operator can use a separate port and protocol for the metrics endpoint.
How can this PR be verified?
run
./bin/run_testsIs there any change in kubo-release?
no
Is there any change in kubo-ci?
no
Does this affect upgrade, or is there any migration required?
no
Which issue(s) this PR fixes:
related to cloudfoundry-incubator/cfcr-etcd-release#9
Release note: