This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Support dockerconfigjson secret #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardstudy
force-pushed
the
ed/dockerconfigjson
branch
from
ade9032
to
c21aae0
Compare
edwardstudy
force-pushed
the
ed/dockerconfigjson
branch
from
c21aae0
to
186d59c
Compare
edwardstudy
changed the title
edwardstudy
force-pushed
the
ed/dockerconfigjson
branch
6 times, most recently
from
4b53daa
to
70aacca
Compare
cppforlife
reviewed
Jul 14, 2020
| imageCredentials: | ||
| registry: fake-registry | ||
| username: fake-username | ||
| password: fake-password |
There was a problem hiding this comment.
storing password value in a CR is not safe because contents are not encrypted (unlike contents of Secret kind).
additionally it seems that this conflates generation functionality of QuarksSecret with encoding of existing data into a different format (no generation going on).
manno
suggested changes
Jul 20, 2020
edwardstudy
force-pushed
the
ed/dockerconfigjson
branch
from
70aacca
to
a617508
Compare
edwardstudy
force-pushed
the
ed/dockerconfigjson
branch
from
a617508
to
077eb03
Compare
manno
approved these changes
Aug 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#172394617