Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Only trigger secret updates for changes to the qsec spec #57

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

manno
Copy link
Member

@manno manno commented Sep 25, 2020

Don't trigger for label

#174985178

@coveralls
Copy link

coveralls commented Sep 25, 2020

Pull Request Test Coverage Report for Build 272409855

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 77.742%

Files with Coverage Reduction New Missed Lines %
pkg/kube/controllers/quarkssecret/certificatesigningrequest_controller.go 1 80.49%
pkg/kube/controllers/quarkssecret/certificatesigningrequest_reconciler.go 4 87.63%
Totals Coverage Status
Change from base Build 258438662: -0.05%
Covered Lines: 1219
Relevant Lines: 1568

💛 - Coveralls

return true
}
// reconcile if it was already generated and the spec changed
// reconcile if it was already generated and controller requested update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@manno manno merged commit b930043 into master Sep 25, 2020
@manno manno deleted the only-trigger-for-spec-174985178 branch September 25, 2020 12:55
manno pushed a commit to cloudfoundry-incubator/quarks-operator that referenced this pull request Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants