Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing disk with enable_cpi_resize_disk option gets error "<disk> contains a partition created by bosh. No partitioning is allowed" #221

Closed
pivotal-todd-robbins opened this issue Jul 24, 2019 · 6 comments
Labels

Comments

@pivotal-todd-robbins
Copy link

pivotal-todd-robbins commented Jul 24, 2019

Parted partioner checks added into BOSH agent in Xenial appear to be incompatible with enable_cpi_resize_disk CPI option.

Attempting to resize a disk with enable_cpi_resize_disk will fail with error:

L Error: Action Failed get_task: Task f42c8157-6f41-4110-4136-49d311b8f387 result: Mounting persistent disk: Partitioning disk: '/dev/vdb' contains a partition created by bosh. No partitioning is allowed. Task 42 | 15:04:40 | Error: Action Failed get_task: Task f42c8157-6f41-4110-4136-49d311b8f387 result: Mounting persistent disk: Partitioning disk: '/dev/vdb' contains a partition created by bosh. No partitioning is allowed.

enable_cpi_resize_disk flag previously was able to successfully resize disk in trusty though BOSH agent did not have logic to grow filesystem. Now the disk will fail attaching because agent will find partition with name "bosh-partition" when mounting the disk and fail the BOSH task.

It seems checks added in parted_partitioner.go has made it so resizing disk in place via enable_cpi_resize_disk flag cannot work.

@pivotal-todd-robbins pivotal-todd-robbins changed the title Resizing disk with enable_cpi_resize_disk option gets contains a "partition created by bosh. No partitioning is allowed" error. Resizing disk with enable_cpi_resize_disk option gets error "<disk> contains a partition created by bosh. No partitioning is allowed" Jul 24, 2019
@beyhan
Copy link
Member

beyhan commented Jul 25, 2019

Hi @pivotal-todd-robbins,

this is a known issue and here is the story, which is planed for it. Issue #154 is also related.

@SteveH-US
Copy link

Hi Beyhan,

Neither the story you references about growing the file system nor issue #154 is directly related to this problem. The bosh agent code explicitly disallows resizing the partitions that it created. So, with the introduction of this restriction, neither case would occur.

@beyhan
Copy link
Member

beyhan commented Jul 26, 2019

Yes, this restriction in bosh agent has to change for the resizing use case. This has been analyzed in https://www.pivotaltracker.com/n/projects/1456570/stories/161478343, which is referenced in the top story linked in my previous comment. Thank you for bringing this up. I'm trying to collect all the context around resize issue

@rushs-us
Copy link

I contributed a fix for that here:
#233

@bosh-admin-bot
Copy link

This issue was marked as Stale because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale label or comment below.

@bosh-admin-bot
Copy link

This issue was closed because it has been labeled Stale for 7 days without subsequent activity. Feel free to re-open this issue at any time by commenting below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants