Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview (three changes):
vendor/package
path. Thevendor/cache
path is not used, as that is a special path managed by Bundler and, when present, will include all of the gems referenced by the project, including the development gems that we want to exclude in the built release.Bosh::Cpi::RegistryClient
, so we can remove the dependency onbosh-registry
, thereby also removing many transitive dependencies that are not actually need for the CPI.Notes of Interest:
bosh_cpi
dependency to a slightly older version. This is because the newest versions at this point in time were build from "hotfixes" and do not include theBosh::Cpi::RegistryClient
change. Once that change makes it to "master", and subsequent gems are published, this version lock should be removed (along with thebosh-common
lock).ENV
config options are found in version1.8.2
), I recommend that the version be bumped to latest:1.11.2
Context/Details from an Earlier Conversation with Abel: