Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry once and only once if CPI receives AzureConflictError when deleting a managed disk #269

Conversation

bingosummer
Copy link
Contributor

  • Please check this box once you have run the unit tests
    pushd src/bosh_azure_cpi
      bundle install
      bundle exec rspec spec/unit/*
    popd
    

The coverage is changed from 2483 / 2724 LOC (91.15%) covered to 2492 / 2733 LOC (91.18%) covered.

Changelog

  • When deleting managed disks, Azure may return an AzureConflictError with no retry_after if the disk is used by another operation. This commit is a workaround to handle the error. CPI will retry once and give up if it still fails. After Azure adds retry-after in the response header, the workaround can be removed because the retry in azure_client2 will be triggered by retry_after.

@cfdreddbot
Copy link

Hey bingosummer!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@AbelHu AbelHu merged commit a05a68c into cloudfoundry:master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants