Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM should be in same location with VNET #274

Merged
merged 1 commit into from
Jun 1, 2017

Conversation

gossion
Copy link
Contributor

@gossion gossion commented May 31, 2017

  • Please check this box once you have run the unit tests
    pushd src/bosh_azure_cpi
      bundle install
      bundle exec rspec spec/unit/*
    popd
    

523 examples, 0 failures. 2509 / 2749 LOC (91.27%) covered.

Changelog

  • Use VNET's location as the location for VM related resources.
    In Azure, these VM related resources must be in the same location:
    1. VM
    2. VNET/NIC
    3. Disks
    4. ...

For managed disk, Azure will not explicitly use a storage account, so it is reasonable to deprecate storage_account_location and use VNET's location as the location to create these VM related resources.

@cfdreddbot
Copy link

Hey gossion!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@AbelHu AbelHu merged commit 3af51c0 into cloudfoundry:master Jun 1, 2017
@gossion gossion deleted the read-location-from-vnet branch August 16, 2018 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants