Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support large disk, and add new available vm size #289

Merged
merged 1 commit into from
Jul 14, 2017

Conversation

gossion
Copy link
Contributor

@gossion gossion commented Jul 14, 2017

  • Please check this box once you have run the unit tests
    pushd src/bosh_azure_cpi
      bundle install
      bundle exec rspec spec/unit/*
    popd
    

633 examples, 0 failures. 2760 / 2928 LOC (94.26%) covered.

Changelog

  • Support large disk, and add new available vm size

@cfdreddbot
Copy link

Hey gossion!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@AbelHu
Copy link
Contributor

AbelHu commented Jul 14, 2017

@gossion Could you check why the code coverage drops from 94.6% to 94.26%?

@gossion
Copy link
Contributor Author

gossion commented Jul 14, 2017

@AbelHu the coverage does not drop. I run the unit test before rebasing to upstream branch. here is the data by re-run the unit test after the rebase:
643 examples, 0 failures. 2786 / 2945 LOC (94.6%) covered.

@AbelHu AbelHu merged commit 533dd7a into cloudfoundry:master Jul 14, 2017
@gossion gossion deleted the large-disk branch August 16, 2018 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants